sven-lange-last commented on a change in pull request #3835: Limit of binary
actions is too low.
URL:
https://github.com/apache/incubator-openwhisk/pull/3835#discussion_r203029779
##########
File path: ansible/group_vars/all
##########
@@ -56,6 +56,8 @@ limits:
concurrentInvocationsSystem: "{{ limit_invocations_concurrent_system |
default(5000) }}"
firesPerMinute: "{{ limit_fires_per_minute | default(60) }}"
sequenceMaxLength: "{{ limit_sequence_max_length | default(50) }}"
+ actionCodeMb: "{{ limit_action_code_mb | default(48) }}"
+ parametersMb: "{{ limit_parameters_mb | default(1) }}"
Review comment:
I suggest to add a comment indicating that this size limit also applies to
annotations, not only to parameters. And in contrast to the action code size
limit, this is a gross limit because we do not perform any Base64 encoding for
parameters / annotations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
