tysonnorris commented on a change in pull request #3812: ContainerClient + akka
http alternative to HttpUtils
URL:
https://github.com/apache/incubator-openwhisk/pull/3812#discussion_r204115351
##########
File path:
core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainer.scala
##########
@@ -190,29 +190,33 @@ class DockerContainer(protected val id: ContainerId,
implicit transid: TransactionId): Future[RunResult] = {
val started = Instant.now()
val http = httpConnection.getOrElse {
- val conn = new HttpUtils(s"${addr.host}:${addr.port}", timeout,
ActivationEntityLimit.MAX_ACTIVATION_ENTITY_LIMIT)
+ val conn = new ApacheBlockingContainerClient(
+ s"${addr.host}:${addr.port}",
+ timeout,
+ ActivationEntityLimit.MAX_ACTIVATION_ENTITY_LIMIT)
Review comment:
Also noticed that `ActivationEntityLimit.MAX_ACTIVATION_ENTITY_LIMIT` is not
used in `Container.scala`... These are both 1mb, but docs for
`MAX_ACTIVATION_LIMIT` says _This refers to the invoke-time parameters_ - but
in this case we are limiting the response size (and I don't see any assertion
of limit on the request entity size in former HttpUtils?).
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
