tysonnorris commented on a change in pull request #3812: ContainerClient + akka http alternative to HttpUtils URL: https://github.com/apache/incubator-openwhisk/pull/3812#discussion_r204126416
########## File path: tests/src/test/scala/whisk/core/containerpool/docker/test/AkkaContainerClientTests.scala ########## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package whisk.core.containerpool.docker.test + +import common.StreamLogging +import common.WskActorSystem +import java.nio.charset.StandardCharsets +import java.time.Instant +import org.apache.http.HttpRequest +import org.apache.http.HttpResponse +import org.apache.http.entity.StringEntity +import org.apache.http.localserver.LocalServerTestBase +import org.apache.http.protocol.HttpContext +import org.apache.http.protocol.HttpRequestHandler +import org.junit.runner.RunWith +import org.scalatest.BeforeAndAfter +import org.scalatest.BeforeAndAfterAll +import org.scalatest.FlatSpec +import org.scalatest.Matchers +import org.scalatest.junit.JUnitRunner +import scala.concurrent.Await +import scala.concurrent.TimeoutException +import scala.concurrent.duration._ +import spray.json.JsObject +import whisk.common.TransactionId +import whisk.core.containerpool.AkkaContainerClient +import whisk.core.entity.ActivationResponse._ +import whisk.core.entity.size._ + +/** + * Unit tests for AkkaContainerClientTests which communicate with containers. + */ +@RunWith(classOf[JUnitRunner]) +class AkkaContainerClientTests + extends FlatSpec + with Matchers + with BeforeAndAfter + with BeforeAndAfterAll + with StreamLogging + with WskActorSystem { + + implicit val transid = TransactionId.testing + implicit val ec = actorSystem.dispatcher + + var testHang: FiniteDuration = 0.second + var testStatusCode: Int = 200 + var testResponse: String = null + var testConnectionFailCount: Int = 0 + + val mockServer = new LocalServerTestBase { + var failcount = 0 + override def setUp() = { + super.setUp() + this.serverBootstrap + .registerHandler( + "/init", + new HttpRequestHandler() { + override def handle(request: HttpRequest, response: HttpResponse, context: HttpContext) = { + if (testHang.length > 0) { + Thread.sleep(testHang.toMillis) + } + if (testConnectionFailCount > 0 && failcount < testConnectionFailCount) { + failcount += 1 + println("failing in test") + throw new RuntimeException("failing...") + } + response.setStatusCode(testStatusCode); + if (testResponse != null) { + response.setEntity(new StringEntity(testResponse, StandardCharsets.UTF_8)) + } + } + }) + } + } + + mockServer.setUp() + val httpHost = mockServer.start() + val hostWithPort = s"${httpHost.getHostName}:${httpHost.getPort}" + + before { + testHang = 0.second + testStatusCode = 200 + testResponse = null + testConnectionFailCount = 0 + stream.reset() + } + + override def afterAll = { + mockServer.shutDown() + } + + behavior of "PoolingContainerClient" + + it should "not wait longer than set timeout" in { + val timeout = 5.seconds + val connection = new AkkaContainerClient(httpHost.getHostName, httpHost.getPort, timeout, 1.B, 100) + testHang = timeout * 2 + val start = Instant.now() + val result = Await.result(connection.post("/init", JsObject.empty, retry = true), 10.seconds) + + val end = Instant.now() + val waited = end.toEpochMilli - start.toEpochMilli + result shouldBe 'left + waited should be > timeout.toMillis + waited should be < (timeout * 2).toMillis + } + + it should "handle empty entity response" in { + val timeout = 5.seconds + val connection = new AkkaContainerClient(httpHost.getHostName, httpHost.getPort, timeout, 1.B, 100) + testStatusCode = 204 + val result = Await.result(connection.post("/init", JsObject.empty, retry = true), 10.seconds) + result shouldBe Left(NoResponseReceived()) + } + + it should "retry till timeout on StreamTcpException" in { + val timeout = 5.seconds + val connection = new AkkaContainerClient("0.0.0.0", 12345, timeout, 1.B, 100) + val start = Instant.now() + val result = Await.result(connection.post("/init", JsObject.empty, retry = true), 10.seconds) + val end = Instant.now() + val waited = end.toEpochMilli - start.toEpochMilli + result should be('left) + result.left.get shouldBe a[Timeout] + result.left.get.asInstanceOf[Timeout].t shouldBe a[TimeoutException] Review comment: agreed ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
