tysonnorris commented on issue #3812: ContainerClient + akka http alternative 
to HttpUtils
URL: 
https://github.com/apache/incubator-openwhisk/pull/3812#issuecomment-406812743
 
 
   @markusthoemmes I added one more forgotten required change: enable 
ActionContainer based tests to explicitly use akka vs apache http client. While 
it is true that this could be accomplished by coercing test's akka config to 
include `akka-client: true`,  I think that until akka is the default client, 
tests should not be forced to run with multiple configs, but we still need to 
be able to force tests to run via a specific client (e.g. concurrency tests 
will fail on apache client, but not the akka client...).
   For example forcing use of akka client will be done in container tests by 
changing: 
   `withContainer(nodejsContainerImageName, env)(code)` to 
   `withContainer(nodejsContainerImageName, env, true)(code)`
   WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to