tysonnorris commented on issue #3812: ContainerClient + akka http alternative 
to HttpUtils
URL: 
https://github.com/apache/incubator-openwhisk/pull/3812#issuecomment-407219720
 
 
   So for docker "bad proxy" and "bad action" tests, to keep behavior parity, 
we need to change retry logic from:
   ```
   case t: StreamTcpException if retry
   ```
   to 
   ```
   case t: RuntimeException if retry
   ``` 
   because in some cases, akka http throws 
`UnexpectedConnectionClosureException`, which is private but extends 
`RuntimeException`. 
   Some discussion is here: https://github.com/akka/akka-http/issues/768 in 
case you wonder about catching this specific exception...
   
   Alternatively, we can update test cases for this edgy behavior handling? 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to