markusthoemmes commented on a change in pull request #3892: Use the authz
provider to retrieve the identity of the namespace
URL:
https://github.com/apache/incubator-openwhisk/pull/3892#discussion_r204408378
##########
File path:
core/controller/src/main/scala/whisk/core/controller/WebActions.scala
##########
@@ -457,7 +458,7 @@ trait WhiskWebActionsApi extends Directives with
ValidateRequestSize with PostAc
* This method is factored out to allow mock testing.
*/
protected def getIdentity(namespace: EntityName)(implicit transid:
TransactionId): Future[Identity] = {
- Identity.get(authStore, namespace)
+
SpiLoader.get[AuthenticationDirectiveProvider].namespaceIdentity(namespace)(transid,
authStore)
Review comment:
You'll want to cache the call to
`SpiLoader.get[AuthenticationDirectiveProvider]`. That's not something which
should be executed on a per request basis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
