markusthoemmes commented on a change in pull request #3892: Use the authz
provider to retrieve the identity of the namespace
URL:
https://github.com/apache/incubator-openwhisk/pull/3892#discussion_r204409413
##########
File path: core/controller/src/main/scala/whisk/core/controller/RestAPIs.scala
##########
@@ -323,4 +323,6 @@ trait AuthenticationDirectiveProvider extends Spi {
def authenticate(implicit transid: TransactionId,
authStore: AuthStore,
logging: Logging): AuthenticationDirective[Identity]
+
+ def namespaceIdentity(namespace: EntityName)(implicit transid:
TransactionId, authStore: AuthStore): Future[Identity]
Review comment:
Should we rename this to something more descriptive, like
`identityByNamespace`? A little bit of ScalaDoc would help for context, i.e.:
```scala
/**
* Retrieves an Identity based on a given namespace name.
*
* For use-cases of anonymous invocation (i.e. WebActions),
* we need to an identity based on a given namespace-name to
* give the invocation all the context needed.
*/
```
A little bit of ScalaDoc for `authenticate` would be great in the same vain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
