chetanmeh commented on a change in pull request #2795: enable concurrent
activation processing
URL:
https://github.com/apache/incubator-openwhisk/pull/2795#discussion_r218445298
##########
File path:
core/controller/src/main/scala/whisk/core/loadBalancer/ShardingContainerPoolBalancer.scala
##########
@@ -137,7 +137,18 @@ import scala.util.{Failure, Success}
* - If a loadbalancer leaves or joins the cluster, all state is removed and
created from scratch. Those events should
* not happen often.
*/
-class ShardingContainerPoolBalancer(config: WhiskConfig, controllerInstance:
ControllerInstanceId)(
+class ShardingContainerPoolBalancer(
+ config: WhiskConfig,
+ controllerInstance: ControllerInstanceId,
+ private val feedFactory: (ActorRefFactory, MessagingProvider, (Array[Byte])
=> Future[Unit]) => ActorRef,
Review comment:
@tysonnorris May be we can use traits here instead of function arguments. It
makes it easy in IDE to see what is the implementation and move back and forth
easily
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
