chetanmeh commented on a change in pull request #2795: enable concurrent
activation processing
URL:
https://github.com/apache/incubator-openwhisk/pull/2795#discussion_r225497006
##########
File path:
core/invoker/src/main/scala/whisk/core/containerpool/ContainerProxy.scala
##########
@@ -212,10 +222,34 @@ class ContainerProxy(
// and we keep it in case we need to destroy it.
case Event(data: PreWarmedData, _) => stay using data
- // Run was successful
- case Event(data: WarmedData, _) =>
+ // Init was successful
+ case Event(data: WarmedData, _: PreWarmedData) =>
Review comment:
Note for myself - In `Started` state following sequence happens
1. proxy transitions to `Running` with `PreWarmedData` (activeCount = 1).
2. It also then sends msg `WarmedData` (count = 1) in `initializeAndRun` .
Assuming this is first `Run` being processed
3. It also then sends msg `WarmedData` with count = 0
So each call to `initializeAndRun` end up sending 2 `WarmedData` messages.
One with count = 0 and one with count at time of start of message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
