ruediger-maass commented on a change in pull request #4299: Avoid that actions
do not stop after action timeout when logging heavily
URL:
https://github.com/apache/incubator-openwhisk/pull/4299#discussion_r260731391
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/entity/ActivationResult.scala
##########
@@ -45,6 +48,15 @@ protected[core] case class ActivationResponse private (val
statusCode: Int, val
def isSuccess = statusCode == ActivationResponse.Success
def isApplicationError = statusCode == ActivationResponse.ApplicationError
def isContainerError = statusCode == ActivationResponse.DeveloperError
+ def isContainerTimeoutError(timeout: FiniteDuration) = {
+ statusCode == ActivationResponse.DeveloperError &&
+ (result.get match {
Review comment:
done, handled the case in the new method `isTimedoutActivation` in
`WhiskActivation`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
