ruediger-maass commented on a change in pull request #4299: Avoid that actions
do not stop after action timeout when logging heavily
URL:
https://github.com/apache/incubator-openwhisk/pull/4299#discussion_r260797901
##########
File path:
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerProxy.scala
##########
@@ -581,19 +581,30 @@ class ContainerProxy(
val initRunInterval = initInterval
.map(i =>
Interval(runInterval.start.minusMillis(i.duration.toMillis), runInterval.end))
.getOrElse(runInterval)
- ContainerProxy.constructWhiskActivation(job, initInterval,
initRunInterval, response)
+ ContainerProxy.constructWhiskActivation(
+ job,
+ initInterval,
+ initRunInterval,
+ runInterval.duration >= actionTimeout,
Review comment:
additional remark to the comment above regarding _"old implementation based
on milli seconds_": it is meant that we have changed back to `<=` comparisons
for timeouts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
