sciabarracom commented on a change in pull request #72: Static Build, 
Versioning and Support for More Languages
URL: 
https://github.com/apache/incubator-openwhisk-runtime-go/pull/72#discussion_r260900356
 
 

 ##########
 File path: actionloop/build.gradle
 ##########
 @@ -15,5 +15,19 @@
  * limitations under the License.
  */
 
-ext.dockerImageName = 'actionloop'
+ext.dockerImageName = 'actionloop-v1.0.2'
 
 Review comment:
   Yes I DO want to embed some versionin on the image, but I plan to do this 
only when something important changes. ActionLoop is now a bit special since 
there are now many runtimes depending on it and I cannot change it lightly. Now 
it is built statically and can be used in cases when the ordinary actionloop 
cannot be used. If you had a build with Alpine you HAVE to depend on 
actionloop-v1.0.2 since the ordinary one cannot. But I do not plan to change 
the version all the time, only when breaking changes happens.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to