sven-lange-last commented on a change in pull request #4325: Add error log when
fetching an action from cloudant fails
URL:
https://github.com/apache/incubator-openwhisk/pull/4325#discussion_r262878998
##########
File path:
core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala
##########
@@ -244,7 +244,8 @@ class InvokerReactive(
ActivationResponse.applicationError(Messages.actionRemovedWhileInvoking)
case _: DocumentTypeMismatchException | _:
DocumentUnreadable =>
ActivationResponse.whiskError(Messages.actionMismatchWhileInvoking)
- case _ =>
+ case e =>
+ logging.error(this,
s"${Messages.actionFetchErrorWhileInvoking} Error: ${e.getMessage}")
Review comment:
@markusthoemmes are you talking about the `ArtifactStore` implementations -
for example:
https://github.com/apache/incubator-openwhisk/blob/master/common/scala/src/main/scala/org/apache/openwhisk/core/database/CouchDbRestStore.scala#L217?
If yes - I missed that we already log information there.
Honestly, I don't understand what's going on here:
https://github.com/apache/incubator-openwhisk/blob/master/common/scala/src/main/scala/org/apache/openwhisk/core/database/CouchDbRestStore.scala#L242.
First, we finished the transaction and later on via `reportFailure()`, we fail
it because an exception is thrown?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
