sven-lange-last commented on a change in pull request #4325: Add error log when
fetching an action from cloudant fails
URL:
https://github.com/apache/incubator-openwhisk/pull/4325#discussion_r263345692
##########
File path:
core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala
##########
@@ -244,7 +244,8 @@ class InvokerReactive(
ActivationResponse.applicationError(Messages.actionRemovedWhileInvoking)
case _: DocumentTypeMismatchException | _:
DocumentUnreadable =>
ActivationResponse.whiskError(Messages.actionMismatchWhileInvoking)
- case _ =>
+ case e =>
+ logging.error(this,
s"${Messages.actionFetchErrorWhileInvoking} Error: ${e.getMessage}")
Review comment:
@rabbah You are right. I missed that... Can you please have a look here?
My understanding is that we have the following flow:
1. `Left(code)` matches.
2. `transid.finished()` is called.
3. A new exception is thrown, failing Future `f`.
4. `reportFailure()` is called with the failed `f`. Error handling calls
`transid.failed()`.
Do your agree? What's the rationale behind finishing the transaction first
and then failing it?
https://github.com/apache/incubator-openwhisk/blob/a08175f05cd9bf21e48eea52be62ca0030f9c2c3/common/scala/src/main/scala/org/apache/openwhisk/core/database/CouchDbRestStore.scala#L242-L258
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
