selfxp commented on a change in pull request #4348: Fixes the issue of failing
to read empty Splunk JSON objects
URL:
https://github.com/apache/incubator-openwhisk/pull/4348#discussion_r265855382
##########
File path:
common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/logging/SplunkLogStore.scala
##########
@@ -137,10 +137,17 @@ class SplunkLogStore(
ActivationLogs(
r.results
.map(l =>
- //format same as
org.apache.openwhisk.core.containerpool.logging.LogLine.toFormattedString
-
f"${l.fields(splunkConfig.logTimestampField).convertTo[String]}%-30s ${l
- .fields(splunkConfig.logStreamField)
- .convertTo[String]}:
${l.fields(splunkConfig.logMessageField).convertTo[String].trim}"))
+ try {
Review comment:
Thx for the tip @chetanmeh!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
