TPei commented on a change in pull request #4344: add name of missing action in
sequenceComponentNotFound error
URL:
https://github.com/apache/incubator-openwhisk/pull/4344#discussion_r265862882
##########
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/controller/Actions.scala
##########
@@ -660,7 +660,7 @@ trait WhiskActionsApi extends WhiskCollectionAPI with
PostActionActivation with
case _: TooManyActionsInSequence => Future failed
RejectRequest(BadRequest, sequenceIsTooLong)
case _: NoComponentInSequence => Future failed
RejectRequest(BadRequest, sequenceNoComponent)
case _: SequenceWithCycle => Future failed
RejectRequest(BadRequest, sequenceIsCyclic)
- case _: NoDocumentException => Future failed
RejectRequest(BadRequest, sequenceComponentNotFound)
+ case _: NoDocumentException => Future failed
RejectRequest(BadRequest, s"$sequenceComponentNotFound: $sequenceAction")
Review comment:
Ah, this won't work because sequenceAction is the action name, not the
component. This method catches an error that is thrown in
`countAtomicActionsAndCheckCycle`, which handle the sequence components
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
