rabbah commented on a change in pull request #119: An ability to run on Knative
along with OpenWhisk
URL:
https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/119#discussion_r275523772
##########
File path: core/nodejsActionBase/src/service.js
##########
@@ -15,16 +15,21 @@
* limitations under the License.
*/
+
var NodeActionRunner = require('../runner');
-function NodeActionService(config) {
+function NodeActionService(cfg) {
+
var Status = {
ready: 'ready',
starting: 'starting',
running: 'running',
stopped: 'stopped'
};
+ var config = cfg;
Review comment:
why bother with this? the value is available already to the entire class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
