rabbah commented on a change in pull request #119: An ability to run on Knative 
along with OpenWhisk
URL: 
https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/119#discussion_r275634865
 
 

 ##########
 File path: core/nodejsActionBase/src/service.js
 ##########
 @@ -58,11 +61,12 @@ function NodeActionService(config) {
      * @param app express app
      */
     this.start = function start(app) {
-        server = app.listen(app.get('port'), function() {
+        server = app.listen(config.port, function() {
 
 Review comment:
   Priti I think this is the only relevant change in this file. Is that right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to