style95 commented on a change in pull request #4430: Update docker client
version to 18.06.3
URL:
https://github.com/apache/incubator-openwhisk/pull/4430#discussion_r281887055
##########
File path: tests/src/test/scala/ha/ShootComponentsTests.scala
##########
@@ -305,9 +305,8 @@ trait ShootComponentUtils {
def file(path: String) = Try(new
File(path)).filter(_.exists).map(_.getAbsolutePath).toOption
val docker = (file("/usr/bin/docker") orElse
file("/usr/local/bin/docker")).getOrElse("docker")
- val dockerPort = WhiskProperties.getProperty(WhiskConfig.dockerPort)
- Seq(docker, "--host", host + ":" + dockerPort, cmd, component)
+ Seq(docker, cmd, component)
Review comment:
I just want to completely disable remote Docker API from the code as we
don't use it anymore in our normal use cases.
It seems remote docker API is only required for test cases.
We can selectively enable/disable remote API based on the deployment type
such as
production or unit tests.
But it depends on the OW operator, there is still a possibility that Docker
remote API is enabled without consciousness. And it could induce a security
breach.
How about making this test rely on `ssh` command instead?
Then what we need is just to make ssh connection available between target
hosts and machine which runs tests.
(Generally, tests are executed in build machines such as jenkins, this
requirement would be highly likely already met.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
