style95 commented on a change in pull request #4430: Update docker client
version to 18.06.3
URL:
https://github.com/apache/incubator-openwhisk/pull/4430#discussion_r281937782
##########
File path: tests/src/test/scala/ha/ShootComponentsTests.scala
##########
@@ -305,9 +305,8 @@ trait ShootComponentUtils {
def file(path: String) = Try(new
File(path)).filter(_.exists).map(_.getAbsolutePath).toOption
val docker = (file("/usr/bin/docker") orElse
file("/usr/local/bin/docker")).getOrElse("docker")
- val dockerPort = WhiskProperties.getProperty(WhiskConfig.dockerPort)
- Seq(docker, "--host", host + ":" + dockerPort, cmd, component)
+ Seq(docker, cmd, component)
Review comment:
Make sense.
I just wanted to clean up this configuration as well:
https://github.com/apache/incubator-openwhisk/pull/4430/files#diff-85b6ff9e51a5005c641ac4690b975b2cL55
But that's also a viable option.
I will work on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
