[ 
https://issues.apache.org/jira/browse/ORC-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996607#comment-14996607
 ] 

ASF GitHub Bot commented on ORC-21:
-----------------------------------

Github user asandryh commented on a diff in the pull request:

    https://github.com/apache/orc/pull/12#discussion_r44280592
  
    --- Diff: c++/include/orc/Vector.hh ---
    @@ -140,6 +140,11 @@ namespace orc {
          */
         virtual void resize(uint64_t capacity);
     
    +    /**
    +     * Heap memory used by the batch.
    +     */
    +    virtual int64_t memoryUse();
    --- End diff --
    
    Sure, using a separate method is cleaner than returning -1.
    Just to confirm: getMemoryUsage() or getMemoryUse()?


> Add functionality to estimate memory footprint
> ----------------------------------------------
>
>                 Key: ORC-21
>                 URL: https://issues.apache.org/jira/browse/ORC-21
>             Project: Orc
>          Issue Type: Task
>            Reporter: Aliaksei Sandryhaila
>            Assignee: Aliaksei Sandryhaila
>
> ORC library allocates multiple large buffers to read and materialize ORC 
> files. For stability of applications that use the library, it may be 
> desirable to have an estimate (preferably, a tight upper bound) of a memory 
> footprint.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to