[ 
https://issues.apache.org/jira/browse/ORC-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996643#comment-14996643
 ] 

ASF GitHub Bot commented on ORC-21:
-----------------------------------

Github user asandryh commented on a diff in the pull request:

    https://github.com/apache/orc/pull/12#discussion_r44282193
  
    --- Diff: c++/src/Reader.cc ---
    @@ -1081,8 +1081,8 @@ namespace orc {
       }
     
       void ReaderImpl::selectType(const Type& type) {
    -    if (!selectedColumns[static_cast<size_t>(type.getColumnId())]) {
    -      selectedColumns[static_cast<size_t>(type.getColumnId())] = true;
    +    if (!selectedColumns[type.getColumnId()]) {
    --- End diff --
    
    Will fix this, too.


> Add functionality to estimate memory footprint
> ----------------------------------------------
>
>                 Key: ORC-21
>                 URL: https://issues.apache.org/jira/browse/ORC-21
>             Project: Orc
>          Issue Type: Task
>            Reporter: Aliaksei Sandryhaila
>            Assignee: Aliaksei Sandryhaila
>
> ORC library allocates multiple large buffers to read and materialize ORC 
> files. For stability of applications that use the library, it may be 
> desirable to have an estimate (preferably, a tight upper bound) of a memory 
> footprint.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to