[
https://issues.apache.org/jira/browse/ORC-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746171#comment-15746171
]
ASF GitHub Bot commented on ORC-58:
-----------------------------------
Github user majetideepak commented on the issue:
https://github.com/apache/orc/pull/41
Included review comments.
This patch is huge because I split the monolithic Reader.cc into various
files
- Reader.hh/Reader.cc: ReaderImpl and RowReaderImpl
- Statistics.hh/Statistics.cc: ColumnStatisticsImpl, StatisticsImpl,
Type*StatisticsImpl
- StripeStream.hh/StripeStream.cc: StripeStreamsImpl,
StreamInformationImpl, StripeInformationImpl
- Options.hh: ReaderOptions, RowReaderOptions
@omalley any feedback ?
> Move code for reading rows from Reader to RowReader
> ---------------------------------------------------
>
> Key: ORC-58
> URL: https://issues.apache.org/jira/browse/ORC-58
> Project: Orc
> Issue Type: Improvement
> Components: C++
> Reporter: Deepak Majeti
>
> Existing ReaderImpl constructor can throw an exception. This prohibits the
> creation of the reader instance and subsequent access to the schema
> information.
> For instance, an exception can be thrown if the selected column ids do not
> agree with the number of schema columns. The downstream application might
> still want the schema information for logging purposes.
> The scope of this Jira is to move the code to read rows into a new RowReader
> class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
