[
https://issues.apache.org/jira/browse/ORC-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15802727#comment-15802727
]
ASF GitHub Bot commented on ORC-58:
-----------------------------------
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/41
Deepak,
We got a notice of a new problem from Coverity. Can you look at it?
** CID 173749: Uninitialized members (UNINIT_CTOR)
/c++/src/Reader.cc: 259 in
orc::RowReaderImpl::RowReaderImpl(std::shared_ptr<orc::FileContents>, const
orc::RowReaderOptions &)()
________________________________________________________________________________________________________
*** CID 173749: Uninitialized members (UNINIT_CTOR)
/c++/src/Reader.cc: 259 in
orc::RowReaderImpl::RowReaderImpl(std::shared_ptr<orc::FileContents>, const
orc::RowReaderOptions &)()
253 } else {
254 previousRow = firstRowOfStripe[firstStripe]-1;
255 }
256
257 ColumnSelector column_selector(contents.get());
258 column_selector.updateSelected(selectedColumns, options);
>>> CID 173749: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "rowsInCurrentStripe" is not initialized in
this constructor nor in any functions that it calls.
259 }
260
261 const RowReaderOptions& RowReaderImpl::getRowReaderOptions()
const {
262 return options;
263 }
264
> Move code for reading rows from Reader to RowReader
> ---------------------------------------------------
>
> Key: ORC-58
> URL: https://issues.apache.org/jira/browse/ORC-58
> Project: Orc
> Issue Type: Improvement
> Components: C++
> Reporter: Deepak Majeti
> Assignee: Deepak Majeti
> Fix For: 1.3.0
>
>
> Existing ReaderImpl constructor can throw an exception. This prohibits the
> creation of the reader instance and subsequent access to the schema
> information.
> For instance, an exception can be thrown if the selected column ids do not
> agree with the number of schema columns. The downstream application might
> still want the schema information for logging purposes.
> The scope of this Jira is to move the code to read rows into a new RowReader
> class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
