[ 
https://issues.apache.org/jira/browse/ORC-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748911#comment-15748911
 ] 

Owen O'Malley commented on ORC-119:
-----------------------------------

The parts that broke the straight port are ORC-101's major changes to the bloom 
filters and the additional compression codecs. The compression codecs need to 
live in the writer rather than the implementation of the PhysicalWriter except 
for the compression codec used for the protobuf objects.

The PhysicalWriter API introduced in HIVE-14453 is clearly a work in progress 
and needs some more refinement. I believe the goal is to:

* provide a separation between the WriterImpl and the actual layout on disk
* provide the protobuf for the metadata for interpretation and modification

Based on that, we should remove any access to the underlying stream and 
position. 

Does this API meet the need?

https://gist.github.com/omalley/f5d7f8edd8fba47fd6e84c179568672d


> Create an abstraction named PhysicalWriter that abstracts where the Writer 
> puts the bytes
> -----------------------------------------------------------------------------------------
>
>                 Key: ORC-119
>                 URL: https://issues.apache.org/jira/browse/ORC-119
>             Project: Orc
>          Issue Type: Bug
>          Components: Java
>            Reporter: Owen O'Malley
>
> This is a forward port of HIVE-14453, which introduce PhysicalWriter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to