[ 
https://issues.apache.org/jira/browse/ORC-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751814#comment-15751814
 ] 

Owen O'Malley commented on ORC-119:
-----------------------------------

{quote}
1) How is appendDataStream used? If it's just called repeatedly with the same 
name where OutputReceiver.output would formerly be called, that makes sense.
{quote}

Yes, my thought was that when a compressed buffer was full, the writer would 
call appendDataStream with the same name.

{quote}
2) Does compression really need to be in the same layer as encoding? I guess it 
makes sense for the current implementation.
{quote}

I think it will be better and less brittle if the rle and compression are done 
at the same layer. In particular, building the indexes will be done better in a 
single place rather than spread across the layers.

> Create an abstraction named PhysicalWriter that abstracts where the Writer 
> puts the bytes
> -----------------------------------------------------------------------------------------
>
>                 Key: ORC-119
>                 URL: https://issues.apache.org/jira/browse/ORC-119
>             Project: Orc
>          Issue Type: Bug
>          Components: Java
>            Reporter: Owen O'Malley
>
> This is a forward port of HIVE-14453, which introduce PhysicalWriter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to