[jira] [Commented] (ORC-202) Add enum that encodes which writer wrote a file

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ORC-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052250#comment-16052250
 ] 

ASF GitHub Bot commented on ORC-202:
------------------------------------

Github user dain commented on a diff in the pull request:

    https://github.com/apache/orc/pull/132#discussion_r122506523
  
    --- Diff: java/core/src/test/org/apache/orc/TestVectorOrcFile.java ---
    @@ -3039,9 +3039,45 @@ public void testExpansion() throws Exception {
     
       @Test
       public void testWriterVersion() throws Exception {
    -    assertEquals(OrcFile.WriterVersion.FUTURE, 
OrcFile.WriterVersion.from(99));
    -    assertEquals(OrcFile.WriterVersion.ORIGINAL, 
OrcFile.WriterVersion.from(0));
    -    assertEquals(OrcFile.WriterVersion.HIVE_4243, 
OrcFile.WriterVersion.from(2));
    +    // test writer implementation serialization
    +    assertEquals(OrcFile.WriterImplementation.ORC_JAVA,
    +        OrcFile.WriterImplementation.from(0));
    +    assertEquals(OrcFile.WriterImplementation.ORC_CPP,
    +        OrcFile.WriterImplementation.from(1));
    +    assertEquals(OrcFile.WriterImplementation.PRESTO,
    +        OrcFile.WriterImplementation.from(2));
    +    assertEquals(OrcFile.WriterImplementation.UNKNOWN,
    +        OrcFile.WriterImplementation.from(99));
    +
    +    // test writer version serialization
    +    assertEquals(OrcFile.WriterVersion.FUTURE,
    +        OrcFile.WriterVersion.from(OrcFile.WriterImplementation.ORC_JAVA, 
99));
    +    assertEquals(OrcFile.WriterVersion.ORIGINAL,
    +        OrcFile.WriterVersion.from(OrcFile.WriterImplementation.ORC_JAVA, 
0));
    +    assertEquals(OrcFile.WriterVersion.HIVE_4243,
    +        OrcFile.WriterVersion.from(OrcFile.WriterImplementation.ORC_JAVA, 
2));
    +    assertEquals(OrcFile.WriterVersion.FUTURE,
    +        OrcFile.WriterVersion.from(OrcFile.WriterImplementation.ORC_CPP, 
99));
    +    assertEquals(OrcFile.WriterVersion.ORC_CPP_ORIGINAL,
    +        OrcFile.WriterVersion.from(OrcFile.WriterImplementation.ORC_CPP, 
0));
    +    assertEquals(OrcFile.WriterVersion.ORC_CPP_ORIGINAL,
    --- End diff --
    
    Add a test for the Presto version?


> Add enum that encodes which writer wrote a file
> -----------------------------------------------
>
>                 Key: ORC-202
>                 URL: https://issues.apache.org/jira/browse/ORC-202
>             Project: ORC
>          Issue Type: Bug
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>
> Add a protobuf enum value in the footer that can encode which writer wrote 
> the file:
> * ORC Java Writer
> * ORC C++ Writer
> * Presto Writer



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)