[
https://issues.apache.org/jira/browse/ORC-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052956#comment-16052956
]
ASF GitHub Bot commented on ORC-202:
------------------------------------
Github user dain commented on a diff in the pull request:
https://github.com/apache/orc/pull/132#discussion_r122575252
--- Diff: java/core/src/java/org/apache/orc/impl/OrcTail.java ---
@@ -70,8 +70,11 @@ public long getFileModificationTime() {
public OrcFile.WriterVersion getWriterVersion() {
OrcProto.PostScript ps = fileTail.getPostscript();
+ OrcProto.Footer footer = fileTail.getFooter();
+ OrcFile.WriterImplementation writer =
+ OrcFile.WriterImplementation.from(footer.getWriter());
return (ps.hasWriterVersion()
--- End diff --
I suggest we make `writerVersion` required for the new writer
implementations, so you would just throw in that case... This is similar to
the reason we are starting with writer version 6
> Add enum that encodes which writer wrote a file
> -----------------------------------------------
>
> Key: ORC-202
> URL: https://issues.apache.org/jira/browse/ORC-202
> Project: ORC
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
>
> Add a protobuf enum value in the footer that can encode which writer wrote
> the file:
> * ORC Java Writer
> * ORC C++ Writer
> * Presto Writer
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
