[ 
https://issues.apache.org/jira/browse/ORC-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055193#comment-16055193
 ] 

ASF GitHub Bot commented on ORC-202:
------------------------------------

Github user omalley commented on the issue:

    https://github.com/apache/orc/pull/132
  
    There are a couple of problems with enums in Protobuf... The main is that 
if it is an unknown value (from a future version) it becomes unset. It is 
important that we can tell the difference between an unset value (orc java 
writer) and some future writer implementation. It is also useful to be able to 
print the value of the unknown enum.
    
    Obviously I wasn't aware of the problems when I wrote the original version 
of orc_proto.proto. I probably should go through and convert them all to 
integers.


> Add enum that encodes which writer wrote a file
> -----------------------------------------------
>
>                 Key: ORC-202
>                 URL: https://issues.apache.org/jira/browse/ORC-202
>             Project: ORC
>          Issue Type: Bug
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 1.5.0
>
>
> Add a protobuf enum value in the footer that can encode which writer wrote 
> the file:
> * ORC Java Writer
> * ORC C++ Writer
> * Presto Writer



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to