[
https://issues.apache.org/jira/browse/ORC-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083140#comment-16083140
]
ASF GitHub Bot commented on ORC-204:
------------------------------------
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/135#discussion_r126829942
--- Diff: cmake_modules/ThirdpartyToolchain.cmake ---
@@ -0,0 +1,90 @@
+set (LZ4_VERSION "1.7.5")
+set (SNAPPY_VERSION "1.1.3")
+set (ZLIB_VERSION "1.2.11")
+set (THIRDPARTY_DIR "${CMAKE_BINARY_DIR}/c++/libs/thirdparty")
+
+string(TOUPPER ${CMAKE_BUILD_TYPE} UPPERCASE_BUILD_TYPE)
+
+# ----------------------------------------------------------------------
+# Snappy
+
+set (SNAPPY_PREFIX "${THIRDPARTY_DIR}/snappy_ep-install")
+set (SNAPPY_HOME "${SNAPPY_PREFIX}")
+set (SNAPPY_INCLUDE_DIRS "${SNAPPY_PREFIX}/include")
+set (SNAPPY_STATIC_LIB_NAME snappy)
+set (SNAPPY_STATIC_LIB
"${SNAPPY_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}${SNAPPY_STATIC_LIB_NAME}${CMAKE_STATIC_LIBRARY_SUFFIX}")
+set (SNAPPY_SRC_URL
"${CMAKE_SOURCE_DIR}/c++/libs/snappy-${SNAPPY_VERSION}.tar.gz")
+if (${UPPERCASE_BUILD_TYPE} EQUAL "RELEASE")
+ set (SNAPPY_CXXFLAGS "CXXFLAGS='-DNDEBUG -O2'")
+endif ()
+
+ExternalProject_Add (snappy_ep
+ CONFIGURE_COMMAND ./configure "--prefix=${SNAPPY_PREFIX}"
${SNAPPY_CXXFLAGS}
+ BUILD_IN_SOURCE 1
+ BUILD_COMMAND ${MAKE}
+ INSTALL_DIR ${SNAPPY_PREFIX}
+ URL ${SNAPPY_SRC_URL}
--- End diff --
+1. I mentioned using HTTP URL(download the tar files) as future work
because I wasn't sure of its impact on current users. I will update to use URLs
in this patch if there are no concerns.
> Upgrade c++ libraries for compression
> -------------------------------------
>
> Key: ORC-204
> URL: https://issues.apache.org/jira/browse/ORC-204
> Project: ORC
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Deepak Majeti
>
> We should upgrade to the current versions of:
> * zlib
> * snappy
> * lz4
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
