[
https://issues.apache.org/jira/browse/ORC-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086616#comment-16086616
]
ASF GitHub Bot commented on ORC-204:
------------------------------------
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/135#discussion_r127358830
--- Diff: cmake_modules/ThirdpartyToolchain.cmake ---
@@ -13,17 +13,18 @@ set (SNAPPY_HOME "${SNAPPY_PREFIX}")
set (SNAPPY_INCLUDE_DIRS "${SNAPPY_PREFIX}/include")
set (SNAPPY_STATIC_LIB_NAME snappy)
set (SNAPPY_STATIC_LIB
"${SNAPPY_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}${SNAPPY_STATIC_LIB_NAME}${CMAKE_STATIC_LIBRARY_SUFFIX}")
-set (SNAPPY_SRC_URL
"${CMAKE_SOURCE_DIR}/c++/libs/snappy-${SNAPPY_VERSION}.tar.gz")
+set (SNAPPY_SRC_URL
"https://github.com/google/snappy/releases/download/1.1.4/snappy-${SNAPPY_VERSION}.tar.gz";)
--- End diff --
this line contains a hard-coded version 1.1.4
> Upgrade c++ libraries for compression
> -------------------------------------
>
> Key: ORC-204
> URL: https://issues.apache.org/jira/browse/ORC-204
> Project: ORC
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Deepak Majeti
>
> We should upgrade to the current versions of:
> * zlib
> * snappy
> * lz4
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
