[
https://issues.apache.org/jira/browse/ORC-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126017#comment-16126017
]
ASF GitHub Bot commented on ORC-226:
------------------------------------
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/151#discussion_r133008869
--- Diff: c++/include/orc/Reader.hh ---
@@ -288,6 +288,17 @@ namespace orc {
virtual uint64_t getCompressionSize() const = 0;
/**
+ * Get ID of writer that generated the file.
+ * Current availiable Orc writers:
+ * 0 = ORC Java
+ * 1 = ORC C++
+ * 2 = Presto
+ * @param id out parameter for writer id
+ * @return true if writer id is availiable, false if otherwise
+ */
+ virtual bool getWriterId(uint32_t & id) const = 0;
--- End diff --
Ok, I see. But I am still not sure about returning ORC_FUTURE. The caller
may want to obtain the exact writer ID for debugging purpose. It can choose to
ignore if it wants. We just give them one more option. What do you think?
> Support getWriterId in c++ reader interface
> -------------------------------------------
>
> Key: ORC-226
> URL: https://issues.apache.org/jira/browse/ORC-226
> Project: ORC
> Issue Type: Sub-task
> Components: C++
> Reporter: Xiening Dai
>
> We just added writer ID to identify files generated by different writers (we
> have three currently). Need an interface for reader to get this ID back.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
