[ https://issues.apache.org/jira/browse/ORC-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162358#comment-16162358 ]
ASF GitHub Bot commented on ORC-226: ------------------------------------ Github user xndai commented on a diff in the pull request: https://github.com/apache/orc/pull/151#discussion_r138235902 --- Diff: c++/include/orc/Reader.hh --- @@ -288,6 +288,18 @@ namespace orc { virtual uint64_t getCompressionSize() const = 0; /** + * Get ID of writer that generated the file. + * @return UNKNOWN_WRITER if the writer ID is undefined + */ + virtual WriterId getWriterId() const = 0; + + /** + * Get the writer id value when getWriterId() returns an unknown writer. + * @return the integer value of the writer ID. + */ + virtual int getUnknownWriterIdValue() const = 0; --- End diff -- Sounds good. I will update it. Thanks. > Support getWriterId in c++ reader interface > ------------------------------------------- > > Key: ORC-226 > URL: https://issues.apache.org/jira/browse/ORC-226 > Project: ORC > Issue Type: Sub-task > Components: C++ > Reporter: Xiening Dai > > We just added writer ID to identify files generated by different writers (we > have three currently). Need an interface for reader to get this ID back. -- This message was sent by Atlassian JIRA (v6.4.14#64029)