[
https://issues.apache.org/jira/browse/ORC-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181283#comment-16181283
]
ASF GitHub Bot commented on ORC-226:
------------------------------------
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/151
Ok, this is generally good. A couple of points that I'll fix as part of
committing:
* the API should use specific types (eg. uint32_t instead of int)
* since the enums are for serialization, I think it will be clearer if we
assign explicit values for them
* if the footer doesn't have a writerId, it is ORC_JAVA_WRITER and not an
exception
> Support getWriterId in c++ reader interface
> -------------------------------------------
>
> Key: ORC-226
> URL: https://issues.apache.org/jira/browse/ORC-226
> Project: ORC
> Issue Type: Sub-task
> Components: C++
> Reporter: Xiening Dai
>
> We just added writer ID to identify files generated by different writers (we
> have three currently). Need an interface for reader to get this ID back.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
