[
https://issues.apache.org/jira/browse/ORC-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332983#comment-16332983
]
ASF GitHub Bot commented on ORC-293:
------------------------------------
Github user rip-nsk commented on a diff in the pull request:
https://github.com/apache/orc/pull/212#discussion_r162753893
--- Diff: c++/src/RLEv1.cc ---
@@ -148,7 +148,7 @@ void RleEncoderV1::write(int64_t value) {
numLiterals += 1;
} else {
numLiterals -= static_cast<int>(MINIMUM_REPEAT - 1);
- long base = literals[numLiterals];
+ int64_t base = literals[numLiterals];
--- End diff --
'auto' is more suitable, but it seems its usage is avoided here
> RleEncoderV1::writeVulong works incorrectly if (sizeof(long) <
> sizeof(int64_t))
> -------------------------------------------------------------------------------
>
> Key: ORC-293
> URL: https://issues.apache.org/jira/browse/ORC-293
> Project: ORC
> Issue Type: Bug
> Reporter: rip.nsk
> Assignee: rip.nsk
> Priority: Blocker
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
