[ 
https://issues.apache.org/jira/browse/ORC-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332993#comment-16332993
 ] 

ASF GitHub Bot commented on ORC-293:
------------------------------------

Github user rip-nsk commented on a diff in the pull request:

    https://github.com/apache/orc/pull/212#discussion_r162755501
  
    --- Diff: c++/src/RLEv1.cc ---
    @@ -169,11 +169,11 @@ void RleEncoderV1::writeVslong(int64_t val) {
     
     void RleEncoderV1::writeVulong(int64_t val) {
       while (true) {
    -    if ((val & ~0x7f) == 0) {
    +    if ((val & ~BASE_128_MASK) == 0) {
    --- End diff --
    
    It is added to match code in RleDecoderV1::readLong


> RleEncoderV1::writeVulong works incorrectly if (sizeof(long) < 
> sizeof(int64_t))
> -------------------------------------------------------------------------------
>
>                 Key: ORC-293
>                 URL: https://issues.apache.org/jira/browse/ORC-293
>             Project: ORC
>          Issue Type: Bug
>            Reporter: rip.nsk
>            Assignee: rip.nsk
>            Priority: Blocker
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to