[
https://issues.apache.org/jira/browse/ORC-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495757#comment-16495757
]
ASF GitHub Bot commented on ORC-343:
------------------------------------
Github user jamesclampffer commented on a diff in the pull request:
https://github.com/apache/orc/pull/273#discussion_r191935614
--- Diff: c++/src/RLE.hh ---
@@ -68,7 +76,24 @@ namespace orc {
* record current position
* @param recorder use the recorder to record current positions
*/
- virtual void recordPosition(PositionRecorder* recorder) const = 0;
+ virtual void recordPosition(PositionRecorder* recorder) const;
+
+ protected:
+ std::unique_ptr<BufferedOutputStream> outputStream;
+ size_t bufferPosition;
+ size_t bufferLength;
+ size_t numLiterals;
+ int64_t* literals;
+ bool isSigned;
+ char* buffer;
--- End diff --
Is this initialized anywhere?
> Enable C++ writer to support RleV2
> ----------------------------------
>
> Key: ORC-343
> URL: https://issues.apache.org/jira/browse/ORC-343
> Project: ORC
> Issue Type: New Feature
> Components: C++
> Reporter: Yurui Zhou
> Priority: Major
>
> Currently only the Java implementation support RleV2 encoder, the C++
> implementation only support RleV2 decoding.
> The issue aims to enable the c++ writer to support RleV2 encoding.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
