[
https://issues.apache.org/jira/browse/ORC-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495992#comment-16495992
]
ASF GitHub Bot commented on ORC-343:
------------------------------------
Github user yuruiz commented on a diff in the pull request:
https://github.com/apache/orc/pull/273#discussion_r191973999
--- Diff: c++/src/Writer.cc ---
@@ -38,9 +38,10 @@ namespace orc {
FileVersion fileVersion;
double dictionaryKeySizeThreshold;
bool enableIndex;
+ RleVersion rleVersion;
--- End diff --
yes, please check the Writer.cc:129 setFileVersion(), we removed
setRleVersion and will only update RleVersion on setting FileVersion.
The reason we still keep RleVersion in WriterOptions is that there is
dependency on RleVersion everywhere, removing it should be done in separate PR.
> Enable C++ writer to support RleV2
> ----------------------------------
>
> Key: ORC-343
> URL: https://issues.apache.org/jira/browse/ORC-343
> Project: ORC
> Issue Type: New Feature
> Components: C++
> Reporter: Yurui Zhou
> Priority: Major
>
> Currently only the Java implementation support RleV2 encoder, the C++
> implementation only support RleV2 decoding.
> The issue aims to enable the c++ writer to support RleV2 encoding.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
