[
https://issues.apache.org/jira/browse/ORC-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501041#comment-16501041
]
ASF GitHub Bot commented on ORC-372:
------------------------------------
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/277#discussion_r192909966
--- Diff: c++/src/TypeImpl.cc ---
@@ -498,54 +506,54 @@ namespace orc {
}
ORC_UNIQUE_PTR<Type> Type::buildTypeFromString(const std::string& input)
{
- std::vector<std::pair<std::string, Type*> > res =
+ std::vector<std::pair<std::string, ORC_UNIQUE_PTR<Type> > > res =
TypeImpl::parseType(input, 0, input.size());
if (res.size() != 1) {
throw std::logic_error("Invalid type string.");
}
- return ORC_UNIQUE_PTR<Type>(res[0].second);
+ return std::move(res[0].second);
}
Type* TypeImpl::parseArrayType(const std::string &input,
--- End diff --
is it better to change return type to unique_ptr as well to be consistent?
same for below.
> Enable valgrind for C++ travis-ci tests
> ---------------------------------------
>
> Key: ORC-372
> URL: https://issues.apache.org/jira/browse/ORC-372
> Project: ORC
> Issue Type: Improvement
> Reporter: Deepak Majeti
> Assignee: Deepak Majeti
> Priority: Major
>
> It will be useful to run valgrind as part of the travis-ci tests
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
