[
https://issues.apache.org/jira/browse/ORC-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501040#comment-16501040
]
ASF GitHub Bot commented on ORC-372:
------------------------------------
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/277#discussion_r192907281
--- Diff: c++/src/TypeImpl.cc ---
@@ -258,31 +258,34 @@ namespace orc {
case STRUCT: {
StructVectorBatch *result = new StructVectorBatch(capacity,
memoryPool);
+ std::unique_ptr<ColumnVectorBatch> return_value =
std::unique_ptr<ColumnVectorBatch>(result);
--- End diff --
maybe we can directly merge line 260 and 261 to a single statement. same
for below.
> Enable valgrind for C++ travis-ci tests
> ---------------------------------------
>
> Key: ORC-372
> URL: https://issues.apache.org/jira/browse/ORC-372
> Project: ORC
> Issue Type: Improvement
> Reporter: Deepak Majeti
> Assignee: Deepak Majeti
> Priority: Major
>
> It will be useful to run valgrind as part of the travis-ci tests
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
