cxzl25 commented on code in PR #1108:
URL: https://github.com/apache/orc/pull/1108#discussion_r869529451
##########
java/core/src/test/org/apache/orc/impl/TestOrcLargeStripe.java:
##########
@@ -214,4 +215,77 @@ public void testStringDirectGreaterThan2GB() throws
IOException {
fs.delete(testFilePath, false);
}
}
+
+ @Test
+ public void testRowBatchSizeWhenStringDirectGreaterThan2GB() throws
IOException {
+ final Runtime rt = Runtime.getRuntime();
+ assumeTrue(rt.maxMemory() > 4_000_000_000L);
Review Comment:
Currently this UT needs a large memory to execute successfully, similar to
`org.apache.orc.impl.TestOrcLargeStripe#testStringDirectGreaterThan2GB`.
At present, I modified the `-Xmx2048m` test of `maven-surefire-plugin`
locally to verify.
Is it possible to increase the 2048m to say 4g or 5g?
I see github runner supports 7g ram.
https://docs.github.com/cn/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
