cxzl25 commented on code in PR #1108:
URL: https://github.com/apache/orc/pull/1108#discussion_r871535151


##########
java/core/src/test/org/apache/orc/impl/TestOrcLargeStripe.java:
##########
@@ -214,4 +215,77 @@ public void testStringDirectGreaterThan2GB() throws 
IOException {
       fs.delete(testFilePath, false);
     }
   }
+
+  @Test
+  public void testRowBatchSizeWhenStringDirectGreaterThan2GB() throws 
IOException {
+    final Runtime rt = Runtime.getRuntime();
+    assumeTrue(rt.maxMemory() > 4_000_000_000L);

Review Comment:
   Make sense.
   Now the trigger condition is that a relatively large string object is 
required. I tried the size as much as possible in this test case, but 2g is 
still not enough.
   I now use the mock method to test this exception.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to