deshanxiao opened a new pull request, #1258:
URL: https://github.com/apache/orc/pull/1258

   ### What changes were proposed in this pull request?
   This PR aims to add a cmake build version in 
[README.md](https://github.com/apache/orc/blob/main/README.md)
   
   
   ### Why are the changes needed?
   [add_compile_definitions 
](https://cmake.org/cmake/help/latest/command/add_compile_definitions.html)only 
supprt cmake 3.12+. We can update the docs 
[README.md](https://github.com/apache/orc/blob/main/README.md)
   
   In ubuntu 18.04:
   
   > sudo apt install cmake
   
   > make ..
   
   we will get an error:
   
   CMake Error at CMakeLists.txt:147 (add_compile_definitions):
     Unknown CMake command "add_compile_definitions".
   
   
   ### How was this patch tested?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to