deshanxiao commented on PR #1258: URL: https://github.com/apache/orc/pull/1258#issuecomment-1254525821
> To help this PR, we need to drop `Ubuntu 18` support. I'm not sure `add_compile_definitions` is worth to drop it, but we can discuss here. > > ``` > $ docker run -it --rm apache/orc-dev:ubuntu18 cmake --version | head -n1 > cmake version 3.10.2 > ``` > > WDYT, @williamhyun , @wgtmac , @guiyanakuang , @stiga-huang ? In CMake docs: > Note This command has been superseded by alternatives: Use [add_compile_definitions()](https://cmake.org/cmake/help/latest/command/add_compile_definitions.html#command:add_compile_definitions) to add preprocessor definitions. Use [include_directories()](https://cmake.org/cmake/help/latest/command/include_directories.html#command:include_directories) to add include directories. Use [add_compile_options()](https://cmake.org/cmake/help/latest/command/add_compile_options.html#command:add_compile_options) to add other options. We could upgrade cmake, although the lower version of add_definitions can do the same thing, but it is deprecated by official. See https://cmake.org/cmake/help/latest/command/add_definitions.html?highlight=add_definitions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
