dongjoon-hyun commented on code in PR #1278:
URL: https://github.com/apache/orc/pull/1278#discussion_r997284976
##########
java/core/src/java/org/apache/orc/impl/DynamicByteArray.java:
##########
@@ -122,29 +121,6 @@ public int add(byte[] value, int valueOffset, int
valueLength) {
return result;
}
- /**
- * Read the entire stream into this array.
- * @param in the stream to read from
- * @throws IOException
- */
- public void readAll(InputStream in) throws IOException {
- int currentChunk = length / chunkSize;
- int currentOffset = length % chunkSize;
- grow(currentChunk);
- int currentLength = in.read(data[currentChunk], currentOffset,
- chunkSize - currentOffset);
- while (currentLength > 0) {
- length += currentLength;
- currentOffset = length % chunkSize;
- if (currentOffset == 0) {
- currentChunk = length / chunkSize;
- grow(currentChunk);
- }
- currentLength = in.read(data[currentChunk], currentOffset,
- chunkSize - currentOffset);
- }
- }
-
Review Comment:
Sorry but I'm -1 for removing like this at 1.9.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
