dongjoon-hyun commented on code in PR #1278:
URL: https://github.com/apache/orc/pull/1278#discussion_r997286747
##########
java/core/src/java/org/apache/orc/impl/DynamicIntArray.java:
##########
@@ -137,8 +135,8 @@ public String toString() {
return sb.append('}').toString();
}
- public int getSizeInBytes() {
- return 4 * initializedChunks * chunkSize;
+ public long getSizeInBytes() {
Review Comment:
From this PR, I believe this is the valid one, but could you make a test
case for the claim?
> In DynamicIntArray#getSizeInBytes, the method should return long to avoid
out of bounds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
