[
https://issues.apache.org/jira/browse/ORC-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655960#comment-17655960
]
Dongjoon Hyun commented on ORC-1348:
------------------------------------
[~zhjwpku] Here are a few tips.
1. `Affected Version` and `Fix Version` should be versions instead of branch
names. We use `1.9.0` for main branch because its version number is
`1.9.0-SNAPSHOT` as of today.
2. `Fix Version` is handled by Apache ORC committers only. Apache ORC
committers will set `Fix Version` after merging the actual PR. So, please don't
fill `Fix Version`.
> TimezoneImpl constructor should pass std::vector<> & instead of std::vector<>
> -----------------------------------------------------------------------------
>
> Key: ORC-1348
> URL: https://issues.apache.org/jira/browse/ORC-1348
> Project: ORC
> Issue Type: Improvement
> Components: C++
> Affects Versions: master
> Reporter: Junwang Zhao
> Priority: Minor
> Fix For: master
>
>
> TimezoneImpl(const std::string& name, const std::vector<unsigned char> bytes)
> should
> change to TimezoneImpl(const std::string& name, const std::vector<unsigned
> char>& bytes) to reduce copy constructor of vector of unsigned char.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
