[
https://issues.apache.org/jira/browse/ORC-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656331#comment-17656331
]
Dongjoon Hyun commented on ORC-1348:
------------------------------------
No problem at all, [~zhjwpku]. I want to give those tips to help you. :)
> TimezoneImpl constructor should pass std::vector<> & instead of std::vector<>
> -----------------------------------------------------------------------------
>
> Key: ORC-1348
> URL: https://issues.apache.org/jira/browse/ORC-1348
> Project: ORC
> Issue Type: Improvement
> Components: C++
> Affects Versions: master
> Reporter: Junwang Zhao
> Priority: Minor
> Fix For: master
>
>
> TimezoneImpl(const std::string& name, const std::vector<unsigned char> bytes)
> should
> change to TimezoneImpl(const std::string& name, const std::vector<unsigned
> char>& bytes) to reduce copy constructor of vector of unsigned char.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
