deshanxiao opened a new pull request, #1387: URL: https://github.com/apache/orc/pull/1387
### What changes were proposed in this pull request? This PR is aimed to enable ENABLE_INDEXES again. ### Why are the changes needed? In https://github.com/apache/orc/pull/1373, we disable the configuration "orc.create.index" because the orc reader cannot work well when orc.create.index=false. The reason why the reader cannot work well because it depends the value of orc.row.index.stride read from orc file. When orc.create.index=false and orc.row.index.stride > 0, the value of orc.create.index will be written to the orc file but the value of orc.row.index.stride will not. When we create a searcher, it will read all the index and then it fails for the empty index. In the process of pickupgroups, if a failure occurs, we should not just exit but read the file with no index. This PR also introduce a new limitation: If orc.create.index=false, it will throw a exception if orc.row.index.stride > 0. ### How was this patch tested? UT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
