guiyanakuang commented on code in PR #1387:
URL: https://github.com/apache/orc/pull/1387#discussion_r1099619062
##########
java/core/src/test/org/apache/orc/impl/TestReaderImpl.java:
##########
@@ -527,4 +527,37 @@ public void testWithoutCompressionBlockSize() throws
IOException {
}
}
}
+
+ @Test
+ public void testSargSkipPickupGroupWithoutIndex() throws IOException {
+ Configuration conf = new Configuration();
+ Path[] paths = new Path[] {
+ new Path(workDir,
"TestOrcFile.testSargSkipPickupGroupWithoutIndexCPlusPlus.orc"),
+ new Path(workDir,
"TestOrcFile.testSargSkipPickupGroupWithoutIndexJava.orc"),
Review Comment:
Please add some descriptions of the test file columns.
##########
java/core/src/test/org/apache/orc/impl/TestReaderImpl.java:
##########
@@ -527,4 +527,37 @@ public void testWithoutCompressionBlockSize() throws
IOException {
}
}
}
+
+ @Test
+ public void testSargSkipPickupGroupWithoutIndex() throws IOException {
+ Configuration conf = new Configuration();
+ Path[] paths = new Path[] {
+ new Path(workDir,
"TestOrcFile.testSargSkipPickupGroupWithoutIndexCPlusPlus.orc"),
+ new Path(workDir,
"TestOrcFile.testSargSkipPickupGroupWithoutIndexJava.orc"),
+ };
+ for (Path path: paths) {
+ FileSystem fs = path.getFileSystem(conf);
+ try (ReaderImpl reader = (ReaderImpl) OrcFile.createReader(path,
+ OrcFile.readerOptions(conf).filesystem(fs))) {
+
+ SearchArgument sarg = SearchArgumentFactory.newBuilder()
+ .startNot()
+ .lessThan("x", PredicateLeaf.Type.LONG, 100000L)
Review Comment:
The test column data is [0-1023]. I think we should use a no-intersection
condition to verify that the pickup is skipped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
